Skip to content

triagebot: label LLVM submodule changes with A-LLVM #141602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

triagebot: label LLVM submodule changes with A-LLVM #141602

merged 1 commit into from
May 27, 2025

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 26, 2025 •
edited by rustbot
Loading

Fixes #141601.

r? @apiraino

@jieyouxu jieyouxu added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 26, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

jieyouxu
jieyouxu commented May 26, 2025
View reviewed changes
@jieyouxu jieyouxu mentioned this pull request May 26, 2025
Closed
apiraino
apiraino approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@apiraino apiraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off we go

@jieyouxu
Copy link
Member Author

(you need to bors in this repo :D)

@jieyouxu
Copy link
Member Author

@bors r=@apiraino rollup

@bors
Copy link
Collaborator

bors commented May 26, 2025

📌 Commit 0dcdf56 has been approved by apiraino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2025
@apiraino
Copy link
Contributor

thanks @jieyouxu

@jieyouxu
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 27, 2025
@jieyouxu
Copy link
Member Author

Added rustc_llvm too.
@bors r=apiraino

@bors
Copy link
Collaborator

bors commented May 27, 2025

📌 Commit e25cf45 has been approved by apiraino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request May 27, 2025
Merged
bors added a commit that referenced this pull request May 27, 2025
@bors
Auto merge of #141662 - matthiaskrgr:rollup-9kt4zj7, r=matthiaskrgr
45f256d 
Rollup of 8 pull requests

Successful merges:

 - #141312 (Add From<TryLockError> for io::Error)
 - #141495 (Rename `{GenericArg,Term}::unpack()` to `kind()`)
 - #141602 (triagebot: label LLVM submodule changes with `A-LLVM`)
 - #141632 (remove `visit_mt` from `ast::mut_visit`)
 - #141640 (test: convert version_check ui test to run-make)
 - #141645 (bump fluent-* crates)
 - #141650 (coverage: Revert "unused local file IDs" due to empty function names)
 - #141654 (tests: mark option-niche-eq as fixed on LLVM 21)

Failed merges:

 - #141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`)
 - #141636 (avoid some usages of `&mut P<T>` in AST visitors)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 732f671 into rust-lang:master May 27, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 27, 2025
rust-timer added a commit that referenced this pull request May 27, 2025
@rust-timer
Unrolled build for #141602
4aa1ebb 
Rollup merge of #141602 - jieyouxu:llvm-submodule, r=apiraino

triagebot: label LLVM submodule changes with `A-LLVM`

Fixes #141601.

r? `@apiraino`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 28, 2025
@bors
Auto merge of #141662 - matthiaskrgr:rollup-9kt4zj7, r=matthiaskrgr
88ab797 
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#141312 (Add From<TryLockError> for io::Error)
 - rust-lang/rust#141495 (Rename `{GenericArg,Term}::unpack()` to `kind()`)
 - rust-lang/rust#141602 (triagebot: label LLVM submodule changes with `A-LLVM`)
 - rust-lang/rust#141632 (remove `visit_mt` from `ast::mut_visit`)
 - rust-lang/rust#141640 (test: convert version_check ui test to run-make)
 - rust-lang/rust#141645 (bump fluent-* crates)
 - rust-lang/rust#141650 (coverage: Revert "unused local file IDs" due to empty function names)
 - rust-lang/rust#141654 (tests: mark option-niche-eq as fixed on LLVM 21)

Failed merges:

 - rust-lang/rust#141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`)
 - rust-lang/rust#141636 (avoid some usages of `&mut P<T>` in AST visitors)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu jieyouxu deleted the llvm-submodule branch May 28, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuviper cuviper cuviper left review comments

@nikic nikic nikic left review comments

@apiraino apiraino apiraino approved these changes

Assignees

@apiraino apiraino

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

Triagebot doesn't autolabel things that change LLVM's submodule

6 participants

@jieyouxu @rustbot @bors @apiraino @cuviper @nikic